Drop the example based on using pip's internals #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip's documentation explicitly states to not use `import pip`: > While it is implemented in Python, and so is available from your Python code via > `import pip`, you must not use pip’s internal APIs in this way. This example is in direct contradiction with the documentation's guidance and, thus, has been removed.
|
Hi there! A gentle nudge on this. |
joshmgross
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pip's documentation explicitly states to not use
import pip:(from https://pip.pypa.io/en/stable/user_guide/#using-pip-from-your-program)
This example is in direct contradiction with the documentation's guidance and, thus, I'd like to see it removed.
(puts on pip maintainer hat) Recommending/suggesting this adds additional support burden for us, since we've spent a bunch of effort to communicate to our users that the code in pip's namespace is not meant-to-be-reused code via
import pip.<whatever>. (takes off hat)