Merged
Conversation
ulgens
approved these changes
Feb 13, 2024
LucasFA
reviewed
Mar 2, 2024
LucasFA
left a comment
There was a problem hiding this comment.
Other than the comment, I was actually surprised that it all was still version 3
|
|
||
| Depending on the environment, huge packages might be pre-installed in the global cache folder. | ||
| With `actions/cache@v3` you can now exclude unwanted packages with [exclude pattern](https://github.com/actions/toolkit/tree/main/packages/glob#exclude-patterns) | ||
| With `actions/cache@v4` you can now exclude unwanted packages with [exclude pattern](https://github.com/actions/toolkit/tree/main/packages/glob#exclude-patterns) |
There was a problem hiding this comment.
I would argue this could be documenting functionality from the prior version. I would just say "From action/cache@v3 onwards [...]"
There was a problem hiding this comment.
update examples to v4 #1311, I will
There was a problem hiding this comment.
It seems the PR got merged without fixing this issue.
Contributor
|
Thank you for this! Let me get this read through today/tomorrow :) |
nebuk89
approved these changes
Aug 14, 2024
Contributor
nebuk89
left a comment
There was a problem hiding this comment.
Thank you for updating all our old tags :) LGTM
Link-
approved these changes
Aug 14, 2024
Member
|
Thank you everyone 🙏 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These changes update all markdown documentation to use the
v4versions of:actions/cache@v4actions/cache/save@v4actions/cache/restore@v4actions/checkout@v4These changes do not update the
.github/workflows. Those are addressed in: #1231Motivation and Context
Up-to-date documentation improves developer happiness.
How Has This Been Tested?
Visual inspection of changes.
Screenshots (if appropriate):
Types of changes
Checklist: