Add Missing Input Reading for only-issue-types
#1298
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes missing input reading for the only-issue-types parameter that was introduced in PR #1255. The functionality was not working because while the parameter was defined, the input value was never actually read from the GitHub Actions input.
- Adds the missing
core.getInput('only-issue-types')call to read the input value - Ensures the
only-issue-typesfeature works as intended
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
kindly pinging @luketomlinson as you've been involved in merging #1255 :) |
luketomlinson
approved these changes
Oct 29, 2025
aparnajyothi-y
approved these changes
Oct 31, 2025
chiranjib-swain
approved these changes
Oct 31, 2025
HarithaVattikuti
approved these changes
Oct 31, 2025
14 tasks
5 tasks
Contributor
Author
|
Hey @HarithaVattikuti may I kindly ask if it would be possible to publish a release including this fix? |
jayudey-wf
pushed a commit
to jayudey-wf/stale
that referenced
this pull request
Dec 4, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up for #1255. Turns out the added functionality was not working because the input was not read. This closed a number of issues for me which I had to repoen 😅
I manually tested the changes proposed here (see python-telegram-bot/python-telegram-bot#5005), so that should hopefully cover it.
Note that I did not add any new unit tests because I also did not find any tests that check this for the other inputs. Maybe a separate issue/PR could track that there is a centralized tests that ensures that all input is respected …
Looking forward to your feedback :)
Related issue:
PR: #1255
Re-closes #1187
Check list: