Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@smorimoto
Copy link
Contributor

@smorimoto smorimoto commented Jul 29, 2020

See #475 for details.

Closes: actions/cache#326

@smorimoto smorimoto force-pushed the posix-archive-format branch from 2657240 to ca5af8e Compare July 29, 2020 15:32
Signed-off-by: Sora Morimoto <[email protected]>
@smorimoto smorimoto force-pushed the posix-archive-format branch from ca5af8e to 2de8727 Compare July 29, 2020 15:33
@smorimoto
Copy link
Contributor Author

@aiqiaoy This should now be in a mergeable state. Could you review it?

@smorimoto
Copy link
Contributor Author

CC: @joshmgross

@joshmgross joshmgross requested a review from aiqiaoy July 31, 2020 14:08
@joshmgross joshmgross added cache enhancement New feature or request labels Jul 31, 2020
@smorimoto
Copy link
Contributor Author

Related issue: actions/cache#326

Copy link
Contributor

@konradpabjan konradpabjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small request to change the package version to 1.0.2 in all the places. Overall looks good! Thanks for submitting this PR ❤️

CC @aiqiaoy

}
}
const args = [
'--posix',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked over the previous PR, I think this won't cause any compat issues. No objections from me 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this shouldn't cause any problems.

@smorimoto smorimoto force-pushed the posix-archive-format branch from 1b2a3cd to 7737589 Compare August 4, 2020 20:15
@smorimoto smorimoto requested a review from konradpabjan August 4, 2020 20:15
@smorimoto smorimoto force-pushed the posix-archive-format branch from 7737589 to 3be5c33 Compare August 4, 2020 20:16
@smorimoto
Copy link
Contributor Author

@konradpabjan Thanks for your review.

@aiqiaoy
Copy link
Contributor

aiqiaoy commented Aug 5, 2020

Yeah sorry I was on-call when I reviewed the original PR and completely forgot about following up. Looks good!

@konradpabjan konradpabjan merged commit 9ad01e4 into actions:main Aug 5, 2020
@konradpabjan
Copy link
Contributor

Version 1.0.2 has been published: https://www.npmjs.com/package/@actions/cache/v/1.0.2

@smorimoto smorimoto deleted the posix-archive-format branch August 5, 2020 19:49
@smorimoto
Copy link
Contributor Author

@konradpabjan Thanks again for your work :)

@smorimoto
Copy link
Contributor Author

@aiqiaoy No worries! I sometimes do something similar to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cache enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve exact timestamps

4 participants