-
Notifications
You must be signed in to change notification settings - Fork 6
Add request Id to logs for easy debugging #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
moritzraho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good start, but here are some suggestions:
- make sure to generate request id on the server (if it is not already done by Runtime). One idea could be to simply reuse the activationID, that would make queries in splunk easier ? (if we are ok to expose it, otherwise a hash of it?)
- include the request id in every log instead of having a start and end log (as logs could come in mixed order for concurrent requests)
The request ID I think is already generated by I/O Runtime, we can add activation ID to this if required. It will have a comma separated x-request-id value something like |
|
Oh ok yes, just tested with an echo action and indeed there is a request id generated |
|
so then ignore my first point, but second point is still valid
|
moritzraho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok lgtm thanks for the changes
Add request Id to logs for easy debugging
Fixes #44
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: