Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented Jan 7, 2023

Allows #70 and #71 to pass (since we are going node-14 and up support anyway).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 7, 2023

Codecov Report

Merging #73 (b495bd8) into master (25fe3e7) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #73   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          387       387           
  Branches        37        37           
=========================================
  Hits           387       387           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

This was referenced Jan 7, 2023
Copy link
Contributor

@MichaelGoberling MichaelGoberling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shazron shazron merged commit 602de0b into master Jan 10, 2023
@shazron shazron deleted the remove-node-12-add-18 branch January 10, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants