Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: public container presign urls #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
moritzraho merged 2 commits into from
Apr 30, 2025
Merged

fix: public container presign urls #194

moritzraho merged 2 commits into from
Apr 30, 2025

Conversation

@moritzraho
Copy link
Member

@moritzraho moritzraho commented Apr 25, 2025 •
edited
Loading

Description

fix adobe/aio-lib-files#81, this doesn't fix byo use cases.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4c6309c) to head (656692a).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #194   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          391       400    +9     
  Branches        41        45    +4     
=========================================
+ Hits           391       400    +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

shazron
shazron reviewed Apr 29, 2025
View reviewed changes
@moritzraho moritzraho merged commit f2ad256 into master Apr 30, 2025
10 checks passed
@moritzraho moritzraho deleted the fix/public-container-presign branch April 30, 2025 12:15
@moritzraho moritzraho mentioned this pull request May 5, 2025
Merged
10 tasks
moritzraho added a commit that referenced this pull request May 5, 2025
@moritzraho
fix: follow-up on #194 (#195)
e75280c 
* use different ids for public and private containers

* tmp

* tmp2

* found fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shazron shazron shazron approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support presignUrls on public files or explicitely throw an error

4 participants

@moritzraho @shazron @MichaelGoberling