Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(breaking-change): update for nodes 18 and 20 #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shazron merged 6 commits into from
Nov 23, 2023
Merged

fix(breaking-change): update for nodes 18 and 20 #547

shazron merged 6 commits into from
Nov 23, 2023

Conversation

@shazron
Copy link
Member

@shazron shazron commented Nov 14, 2023

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f198e20) 100.00% compared to head (dfb5e79) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #547   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          238       238           
  Branches        47        47           
=========================================
  Hits           238       238

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelGoberling MichaelGoberling self-requested a review November 21, 2023 14:43
@moritzraho moritzraho self-assigned this Nov 21, 2023
@moritzraho moritzraho removed their assignment Nov 21, 2023
@shazron shazron merged commit a2f637c into master Nov 23, 2023
@shazron shazron deleted the update-node-18-20 branch November 23, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moritzraho moritzraho moritzraho approved these changes

@MichaelGoberling MichaelGoberling MichaelGoberling approved these changes

Assignees

No one assigned

Labels

breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shazron @moritzraho @MichaelGoberling