fix: update on-push-publish-to-npm.yml #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #635 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 238 238
Branches 47 47
=========================================
Hits 238 238 ☔ View full report in Codecov by Sentry. |
moritzraho
approved these changes
Aug 19, 2024
purplecabbage
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the parameter to the github action, so that on publish, the scope is always public.
If not, we would have to update it in npm manually from private to public, and that requires someone with npm org admin privileges.
This is not a problem if it's already public - but generally when you first publish it (especially for a new repo).
Why this PR? Since we often copy workflows from existing repos, I am adding it here to the 2 most popular repos so this issue won't happen.
Types of changes
Checklist: