-
Notifications
You must be signed in to change notification settings - Fork 39
Bugfix/acna 3561 #744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/acna 3561 #744
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #744 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 238 243 +5
Branches 48 49 +1
=========================================
+ Hits 238 243 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pru55e11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@purplecabbage what are your thoughts on placing this check here? Also, do we want a more generic error message that maybe links to the docs about supported version so this file doesn't become a dependency that needs to get updated every year when we add support for the next version? |
let's discuss with Jesse and I'll re-review after
|
Would love to get some feedback on the verbiage used here. I couldn't find devdocs that point to supported node versions, hence added the link to nvm documentation. |
|
This is good, I would avoid using the term Adobe I/O anywhere new as we have sort of abandoned it ( even though it IS the aio cli ... ) |
|
@dthampy regarding your question about how best not to create future work Then instead of looking just for >22 you could do: |
…e.json file and updated unit tests
|
@pru55e11 @purplecabbage |
pru55e11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @dthampy
|
|
||
| // Check Node.js version | ||
| const nodeVersion = process.version | ||
| if (!semver.satisfies(nodeVersion, config.pjson.engines.node)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it too geeky to output this?
Supported versions are ${config.pjson.engines.node}.
Then we would just have to update package.json and not look at this again :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Checks for node major version greater than 22 and displays a warning message when a non supported node version is detected
Related Issue
725
Motivation and Contex
How Has This Been Tested?
npm link your project locally
Run any aio command. For example:
aio --versionoraio appScreenshots (if appropriate):
Types of changes
Checklist: