Thanks to visit codestin.com
Credit goes to github.com

Skip to content

use default crypto #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
purplecabbage merged 3 commits into from
Oct 5, 2021
Merged

use default crypto #99

purplecabbage merged 3 commits into from
Oct 5, 2021

Conversation

@purplecabbage
Copy link
Member

@purplecabbage purplecabbage commented Sep 23, 2021 •
edited
Loading

Description

Installing new projects there is a warning displayed:

Running npm install for you to install the required dependencies.
npm WARN deprecated [email protected]: This package is no longer supported. It's now a built-in Node module. 
If you've depended on crypto, you should switch to the one that's built-in.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Sep 23, 2021 •
edited
Loading

Codecov Report

Merging #99 (0daf13b) into master (e932bbe) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 0daf13b differs from pull request most recent head cdc37f8. Consider uploading reports for the commit cdc37f8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          557       557           
  Branches        98        98           
=========================================
  Hits           557       557
Impacted Files Coverage Δ
lib/impl/AzureBlobFiles.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e932bbe...cdc37f8. Read the comment docs.

moritzraho
moritzraho approved these changes Sep 23, 2021
View reviewed changes
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@purplecabbage purplecabbage merged commit 6c46fff into master Oct 5, 2021
@purplecabbage purplecabbage deleted the default-crypto branch October 5, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moritzraho moritzraho moritzraho approved these changes

@sandeep-paliwal sandeep-paliwal sandeep-paliwal approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@purplecabbage @moritzraho @sandeep-paliwal