chore: doc change for list #179
Merged
+43
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 576 576
Branches 111 111
=========================================
Hits 576 576 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shazron
requested changes
Apr 30, 2025
purplecabbage
approved these changes
Apr 30, 2025
purplecabbage
requested changes
Apr 30, 2025
Member
purplecabbage
left a comment
There was a problem hiding this comment.
I think we need to over-communicate the fact that paths without a trailing slash are ALWAYS evaluated as a file, and will not return the folder of the same name.
shazron
requested changes
May 5, 2025
shazron
approved these changes
May 5, 2025
amulyakashyap09
approved these changes
May 5, 2025
purplecabbage
approved these changes
May 5, 2025
Member
purplecabbage
left a comment
There was a problem hiding this comment.
Crystal clear! Good job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
will require a release for typings
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: