Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Accepts all kinds of Array-like objects #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 6, 2017
Merged

Accepts all kinds of Array-like objects #97

merged 21 commits into from
Jan 6, 2017

Conversation

@fregante
Copy link
Contributor

@fregante fregante commented Jan 5, 2017 •
edited
Loading

This should now be supported:

balanceText(document.body.children); // HTMLCollection
balanceText(jQuery('.balanceme')); // Array-like

and previously-supported NodeLists and selectors should be slightly faster because I'm skipping the Array.prototype.slice call for all.

Replaces/includes #95 and #96

Brian Genisio and others added 13 commits November 30, 2016 13:19
porting jQuery plugin to VanillaJS
a9acb2f
Supporting CommonJS, AMD, and Browser
ea5cf1e 
Test Plan:
None
making this play nicer with npm
79931b8
Updating after review. Ran jslint and jsmin. Updating to 3.0.0
1bd0187
Updating the function comments/params. Adding build/lint scripts to p…
6ce6f31 
…ackage.json
Updating to include the jQuery wrapper in a single file as an option
2bbaaf4 
Require that the jQuery plugin now be initialized with `$.balanceText()`
Updated the README.js
Turn hasTextWrap into a function to avoid calling on document implicitly
2191a19
@rileyjshaw
Switch to a safer check of window
1a684d7 
re: Khan/react-balance-text#1

Auditors: briangenisio

Test Plan:

- Run through a sample SSR environment with `window` and `document`
  not defined

Should be error-free :)
Changing the interface of the library to be clean and not map to the …
514dcf9 
…jQuery interface directly
Removing the jQuery dependency completely
34601cb
@BrianGenisio
Fixing a small formatting error
a2c120e
@bfred-it
Loop through all Array-likes without prior conversion to Array
79c0a35
@bfred-it
Merge querySelectorAll and getElementsList
5e20a9e
@fregante
Copy link
Contributor Author

fregante commented Jan 5, 2017

I'm gonna make a few more small changes

@BrianGenisio
Copy link
Contributor

Lots of good cleanups in here. I think there is room for a lot more, but to avoid too much of a diff, I think they are warranted in a separate PR.

I'm curious what bugs you were running in to regarding array-likes. I had tested jQuery lists and node lists by hand. I'm glad you codified it, though, in the interface.htm file.

Thanks for these clean-ups :)

This was referenced Jan 5, 2017
Merged
Merged
@fregante
Copy link
Contributor Author

fregante commented Jan 5, 2017 •
edited
Loading

In that "bugs" commit, respectively:

  • typo
  • [el,el].concat(nodelist) is [el,el,nodelist] rather than [el,el,el,el], so concat needs to be applied
  • elements at that point might also be a single element

@redmunds
Copy link
Contributor

redmunds commented Jan 5, 2017 •
edited
Loading

This looks good to me. I tested on Mac10.10/Chrome, Mac10.10/Safari, Win10/Firefox, and Win10/Edge.

@bfred-it @BrianGenisio Any last changes you want to get in before I merge?

@BrianGenisio
Copy link
Contributor

LGTM!!!!

@redmunds redmunds changed the title Accepts all kinds of Array-like objects Remove jQuery Dependency Jan 5, 2017
@redmunds redmunds changed the title Remove jQuery Dependency Accepts all kinds of Array-like objects Jan 5, 2017
@redmunds redmunds merged commit bb9fd69 into adobe:master Jan 6, 2017
@redmunds
Copy link
Contributor

redmunds commented Jan 6, 2017

@BrianGenisio @bfred-it @Rycochet Thanks for your contributions. This is awesome!

@fregante fregante deleted the Khan/native branch January 6, 2017 23:33
@fregante
Copy link
Contributor Author

fregante commented Jan 6, 2017

Excellent! I'll publish to npm this weekend. Remind me if I forget 😂

@fregante
Copy link
Contributor Author

fregante commented Jan 7, 2017

v3 published

Thanks a lot for this, @BrianGenisio!

BrianGenisio pushed a commit to Khan/balance-text that referenced this pull request Jan 7, 2017
@redmunds
Merge pull request adobe#97 from bfred-it/Khan/native
3a815c4 
Accepts all kinds of Array-like objects
@BrianGenisio
Copy link
Contributor

Thanks @bfred-it!!!! So exciting!!! I just published the react-balance-text component using it and it will be going into prod on our site next week.

Also, thanks to @redmunds for this very helpful utility AND for being patient with me on this re-write :)

redmunds added a commit that referenced this pull request Jan 9, 2017
@redmunds
Merge pull request #97 from bfred-it/Khan/native
5307520 
Accepts all kinds of Array-like objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fregante @BrianGenisio @redmunds @rileyjshaw @bfred-it