Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@JasonHowellSlavin
Copy link
Contributor

Description

Adding links two links that utilize the config urls to open previews of both blocks and templates in a new tab. Modifying the preview SVG to match the other svgs used in da-library.js. Creating CSS classes to specifically target the preview icons to align with the addition icons in tool.

https://jira.corp.adobe.com/browse/MWPW-176240

Related Issue

Did not find a related issue.

Motivation and Context

This change gets closer to parity with how the aem sidekick currently works with non-DA environments

How Has This Been Tested?

Tested locally on multiple screen sizes.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…y. Modifies the preview SVG to be in line with other SVGs used in da-library.js
@auniverseaway auniverseaway changed the base branch from main to libprev August 8, 2025 17:35
@auniverseaway auniverseaway merged commit fa9c7de into adobe:libprev Aug 8, 2025
2 of 5 checks passed
auniverseaway added a commit that referenced this pull request Dec 21, 2025
* Add preview link to library block and template Menus (#497)

* Adds a preview link to both block and template sections of the library. Modifies the preview SVG to be in line with other SVGs used in da-library.js

* Adding space

* Updates to library preview (#520)

* Styling is to my liking, full screen modal is in work

* Still working on modal showing w/o removing lib palette

* Working as expected, cleanup necessary, interested to see how the solution goes over

* Full page working

* Removing anchor tag, adding css for UI clarity for template section

* Indentation

* Adding lighter grey shade to new buttons

* Updates for templates section

* Renaming for clarity

* Small css modification

* Code Reveiw changes. Making preview point to aem page

* Fixing most linter errors, some are still triggering with wrong specificity

* Removing last of linting errors

* CR changes: Added a new close button, moved the old close button. Added preview title

* Small change for code sync

* Remove space for code sync

* Remove unnecessary CSS (#680)

* remove hide class css

* Removing additional unecessary css

* Minor UX Tweaks

* 404 handling (#696)

* remove hide class css

* Removing additional unecessary css

* blocks working, working on tempaltes

* Consolidating, adding code that will also work with templates

* Update error message styling in da-library.js

---------

Co-authored-by: Jason Slavin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants