Prevent losing colspan on header when adding columns #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auniverseaway
requested changes
Nov 12, 2025
Member
auniverseaway
left a comment
There was a problem hiding this comment.
Small organizational fix, otherwise this is good.
deps/da-y-wrapper/src/index.js
Outdated
|
|
||
| import { InputRule, inputRules } from 'prosemirror-inputrules'; | ||
|
|
||
| /** |
Member
There was a problem hiding this comment.
I would follow the existing pattern and not write code directly in this file. The basics seem fine, though.
Contributor
Author
There was a problem hiding this comment.
Refactored to use a plugin. Overall think it's a reasonably clean approach, but I won't be heart broken if you tell me this works as designed and isn't worth the trouble, as the default behavior does appear to match word
Signed-off-by: Sean Steimer <[email protected]>
…s. Should be a cleaner approach Signed-off-by: Sean Steimer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
wrap
addColumnBeforeandaddColumnAfterto ensure when doing these from block header, header maintains correct col spanRelated Issue
Motivation and Context
just trying to make things easier to use and prevent modifications that don't make sense in context
How Has This Been Tested?
locally at http://localhost:3000/edit#/aem-sandbox/block-collection/drafts/shsteimer/blocks-
new unit tests on table modifications to document/confirm behaviors
Screenshots (if appropriate):
Types of changes
Checklist: