Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add org level permissions to new org #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rofe wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: add org level permissions to new org #707

rofe wants to merge 4 commits into from

Conversation

@rofe
Copy link
Contributor

@rofe rofe commented Dec 18, 2025

@rofe rofe requested a review from auniverseaway December 18, 2025 14:30
@aem-code-sync
Copy link

aem-code-sync bot commented Dec 18, 2025 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link

aem-code-sync bot commented Dec 18, 2025 •
edited
Loading

Page Scores Audits Google
📱 / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@kptdobe @rofe
feat: auto submit form if org and site are provided (#708)
85fd82b 
* feat: auto submit form if org and site are provided

* chore: provide feedback if error
kptdobe
kptdobe previously approved these changes Dec 19, 2025
View reviewed changes
blocks/start/start.js
const body = new FormData([['config', JSON.stringify(configJson)]]);
const orgResp = await daFetch(orgUrl, { method: 'PUT', body });
if (!orgResp.ok) {
if (orgResp.status === 401 || orgResp.status === 403) {
Copy link
Contributor

@kptdobe kptdobe Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this really happen ?

Copy link
Contributor Author

@rofe rofe Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it prudent to check for... unless we fully trust the window.adobeIMS.isSignedInUser() above?

Copy link
Contributor

@kptdobe kptdobe Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more thinking on the api side. If you have a token, the config api should let you in. At least for the moment...

Copy link
Contributor Author

@rofe rofe Dec 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the org already exists with different permissions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kptdobe kptdobe kptdobe left review comments

@auniverseaway auniverseaway Awaiting requested review from auniverseaway

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Onboarding] Make the user that creates the website the "admin" of it

3 participants

@rofe @kptdobe