Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Added check for visibility attribute specifier #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Nov 9, 2019
Merged

Added check for visibility attribute specifier #51

merged 22 commits into from
Nov 9, 2019

Conversation

@kavanaanand
Copy link
Collaborator

@kavanaanand kavanaanand commented Nov 5, 2019

This change improves Hyde with following capabilities -

  • Checks the visibility of a function/method and also if it explicitly annotated. This adds visibility and visibility_explicit attributes to the JSON method info
  • All the logging statements are executed only when Hyde is running with the verbose option. This cleans up the JSON output to be parsable when HYDE_JSON mode is preferred
  • For some reason, the CommonOptionsParser is duplicating every input file. Hyde now checks and removes the duplicates
  • Added option to process class methods (default is false which is existing behavior)

kavanaanand and others added 21 commits August 29, 2019 11:26
@kavanaanand
added visibility check for functions
ebd4f95
@kavanaanand
removed duplicate file entries
13dd516
resolved conflicts and merged from master
398c139
logging only when verbose
e439d93
Merge remote-tracking branch 'origin/master' into kavana/visibility_s…
336758d 
…pecifier
Revert "Merge remote-tracking branch 'origin/master' into kavana/visi…
fafbf4e 
…bility_specifier"

This reverts commit 336758d, reversing
changes made to e439d93.
support to process class methods and logging inside verbose
a1d60cd
@kavanaanand
added visibility check for functions
8a92177
@kavanaanand
removed duplicate file entries
96768c5
logging only when verbose
98db591
Revert "Merge remote-tracking branch 'origin/master' into kavana/visi…
2788be6 
…bility_specifier"

This reverts commit 336758d, reversing
changes made to e439d93.
support to process class methods and logging inside verbose
845cf8d
cmakelist updated
96db157
Revert "Merge remote-tracking branch 'origin/master' into kavana/visi…
3cee2aa 
…bility_specifier"

This reverts commit 336758d, reversing
changes made to e439d93.
cmakelist updated
0677dc5
Revert "Merge remote-tracking branch 'origin/master' into kavana/visi…
3ee8bde 
…bility_specifier"

This reverts commit 336758d, reversing
changes made to e439d93.
Merge branch 'kavana/visibility_specifier' of github.com:adobe/hyde i…
7fb606b 
…nto kavana/visibility_specifier
Revert "Revert "Merge remote-tracking branch 'origin/master' into kav…
5f8eea5 
…ana/visibility_specifier""

This reverts commit 3ee8bde.
Revert "Revert "Revert "Merge remote-tracking branch 'origin/master' …
bd2f129 
…into kavana/visibility_specifier"""

This reverts commit 5f8eea5.
Revert "Revert "Merge remote-tracking branch 'origin/master' into kav…
c194fd6 
…ana/visibility_specifier""

This reverts commit fafbf4e.
refactoring
78ad2cd
@kavanaanand kavanaanand added enhancement New feature or request good first issue Good for newcomers labels Nov 5, 2019
fosterbrereton
fosterbrereton requested changes Nov 8, 2019
View reviewed changes
Copy link
Contributor

@fosterbrereton fosterbrereton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small changes requested here, and one point of clarification.

matchers/utilities.cpp Outdated
case Visibility::ProtectedVisibility:
info["visibility"] = "protected";
break;
default:
Copy link
Contributor

@fosterbrereton fosterbrereton Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather there not be a default option. That way in case these enumerations change we get a compiler warning about them, instead of values going blank unexpectedly.

Copy link
Collaborator Author

@kavanaanand kavanaanand Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

matchers/function_matcher.cpp

// Do not process class methods here.
if (llvm::dyn_cast_or_null<CXXMethodDecl>(function)) return;
if (!_options._process_class_methods) {
Copy link
Contributor

@fosterbrereton fosterbrereton Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain a bit why this is necessary?

@fosterbrereton
Copy link
Contributor

fosterbrereton commented Nov 9, 2019

LGTM!

@fosterbrereton fosterbrereton merged commit 0d29c9d into master Nov 9, 2019
@fosterbrereton fosterbrereton deleted the kavana/visibility_specifier branch November 9, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fosterbrereton fosterbrereton fosterbrereton requested changes

Assignees

No one assigned

Labels

enhancement New feature or request good first issue Good for newcomers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kavanaanand @fosterbrereton