Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mowijo
Copy link
Contributor

@mowijo mowijo commented Sep 29, 2021

Description

  • Ignoring a multiline comment in LLVM9 as a -Wno-commend in the CMakeLists.txt
  • Adding return statements to methods where gcc cannot deduct that a case will always result in a return being executed.

Related Issue

#69

Motivation and Context

Why is this change required? This change is required to build on Ubuntu 20.04 with LLVM9
*What problem does it solve? * This enables building on Ubuntu 20.04 with LLMV9

How Has This Been Tested?

I didn't find any automated tests to fun, but I ran the

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • N/A I have added tests to cover my changes.
  • N/A- I could not find any tests to run. All new and existing tests passed.

Problems resolved are:

 - Ignoring a multiline comment in LLVM9
 - Adding return statements to methods where gcc cannot deduct
   that a case will always result in a return being executed.
@fosterbrereton
Copy link
Contributor

LGTM; thank you for these changes!

@fosterbrereton fosterbrereton merged commit 8d9c64d into adobe:master Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants