Collect offsets for EMPTY groups #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amuraru
reviewed
Mar 23, 2022
| groupIDs := make([]string, len(groupsRes.AllowedGroups.Groups)) | ||
| for i, group := range groupsRes.AllowedGroups.Groups { | ||
| if group.GroupState != "Empty" && group.GroupState != "Dead" { | ||
| if group.GroupState != "Dead" { |
There was a problem hiding this comment.
these are Smarts groups right? where members join the group only commiting offsets and else the group remains empty right?
Member
Author
There was a problem hiding this comment.
yes, Smarts is one example here
amuraru
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes filtering for EMPTY consumer groups.
Motivation and Context
Kafka consumers using
consumer.assign()method for consuming will be reported as empty consumer groups. We also need to continue reporting offsets when all members of the consumer group left(due to restarts, connectivity issues or any other event).Types of changes
Checklist: