fix(mwpw-169194): sanitizes createdDate format used by the detailsText #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core Web Vitals Metrics
Recorded at: 2025-03-11T13:10:14.846Z |
Core Web Vitals Metrics
Recorded at: 2025-03-11T17:22:43.108Z |
Core Web Vitals Metrics
Recorded at: 2025-03-11T21:38:00.555Z |
sheridansunier
approved these changes
Mar 11, 2025
sanrai
approved these changes
Mar 11, 2025
sanrai
approved these changes
Mar 12, 2025
| const localCreatedDate = new Date(cardDate); | ||
| detailText = localCreatedDate.toLocaleDateString(); | ||
| } else if (detailsTextOption === 'staticDate' && cardDate) { | ||
| const staticDate = new Date(cardDate.replace(/Z$/, '')); |
Collaborator
There was a problem hiding this comment.
This is a very clean solution!
Much better than just splitting by T and taking the left hand (as it'll also localize the dates in the right format)
Core Web Vitals Metrics
Recorded at: 2025-03-12T22:58:12.997Z |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sanitizes createdDate format when the timestamp is set to 00:00:00.0000Z
Simple and effective implementation that when the timestamp is set to 00:00:00.0000Z removes the 'Z' part of the string before creating the JavaScript object and using the local timezone instead of 'GMT'
Test page:
Content as a Service v3 - Tuesday, March 11, 2025 at 10:15