Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(mwpw-169194): sanitizes createdDate format used by the detailsText #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmiqueo merged 4 commits into from
Mar 14, 2025
Merged

fix(mwpw-169194): sanitizes createdDate format used by the detailsText #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f47e01e
fix(MWPW-169194): sanitizes createdDate format
cmiqueo Mar 11, 2025
201608a
fix(mwpw-169194): new implementation after discussion
cmiqueo Mar 11, 2025
1e78f81
fix(MWPW-169194): adds dist files
cmiqueo Mar 12, 2025
ae4d94f
build(MWPW-169194): adds dist files
cmiqueo Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/app.css
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 4 additions & 1 deletion dist/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* Chimera UI Libraries - Build 0.32.4 (3/10/2025, 13:31:48)
* Chimera UI Libraries - Build 0.32.5 (3/12/2025, 15:51:10)
*
*/
/******/ (function(modules) { // webpackBootstrap
Expand Down Expand Up @@ -47074,6 +47074,9 @@ var Card = function Card(props) {
} else if (detailsTextOption === 'createdDate' && cardDate) {
var localCreatedDate = new Date(cardDate);
detailText = localCreatedDate.toLocaleDateString();
} else if (detailsTextOption === 'staticDate' && cardDate) {
var staticDate = new Date(cardDate.replace(/Z$/, ''));
detailText = staticDate.toLocaleDateString();
}

/**
Expand Down
4 changes: 2 additions & 2 deletions dist/main.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/main.source.js
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 3 additions & 0 deletions react/src/js/components/Consonant/Cards/Card.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,9 @@ const Card = (props) => {
} else if (detailsTextOption === 'createdDate' && cardDate) {
const localCreatedDate = new Date(cardDate);
detailText = localCreatedDate.toLocaleDateString();
} else if (detailsTextOption === 'staticDate' && cardDate) {
const staticDate = new Date(cardDate.replace(/Z$/, ''));
Copy link
Collaborator

@sanrai sanrai Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very clean solution!

Much better than just splitting by T and taking the left hand (as it'll also localize the dates in the right format)

detailText = staticDate.toLocaleDateString();
}

/**
Expand Down
Loading