You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Source maps work. Just need to run npm run prebuild to get them triggered and you can debug inside CardsCarousel.jsx
Also can code split css. We just need to import the CSS from the JS, co-locate the files together and webpack will be able to smartly load/bundle them together.
We can decide if we want to do giant bundle releases or individual chunks (or roll them out slowly) but the upside to this is we only need to release chunks of things at a time and not the entire app if only a small part changes. Becomes truly modular. We need to research if any downsides but we can do this migration piece at a time.
Can also lazy load third party dependencies on an add needed basis. Webpack automatically deduplicates modules, so you won’t end up shipping immer twice even if multiple files import it. Here’s how it works in practice:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:

After:

Source maps work. Just need to run
npm run prebuildto get them triggered and you can debug inside CardsCarousel.jsxAlso can code split css. We just need to import the CSS from the JS, co-locate the files together and webpack will be able to smartly load/bundle them together.
We can decide if we want to do giant bundle releases or individual chunks (or roll them out slowly) but the upside to this is we only need to release chunks of things at a time and not the entire app if only a small part changes. Becomes truly modular. We need to research if any downsides but we can do this migration piece at a time.
Can also lazy load third party dependencies on an add needed basis. Webpack automatically deduplicates modules, so you won’t end up shipping immer twice even if multiple files import it. Here’s how it works in practice: