-
Notifications
You must be signed in to change notification settings - Fork 13
feat(mwpw-183491): implements modern carousel style #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cmiqueo
wants to merge
14
commits into
main
Choose a base branch
from
MWPW-183491
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new feature to the CaaS Carousel layout.
It allows the user to choose between two different navigation control styles:
The modern design is a new design the latest version of the CaaS Carousel navigation controls.
The classic design remains unchanged from the original carousel navigation controls design.
THe user will need to select the new Modern design in the CaaS Configuration Tool.
When Carousel layout option is selected, the user will see a drop down with the following options:
The Paged option advances the carousel by one page at a time.
The Incremental option advances the carousel by one card at a time.
There is also a checkbox option to use a light background for the navigation controls.
[x] Light background
This will affect only the Modern design as specified in the Figma files
Resolves
https://jira.corp.adobe.com/browse/MWPW-183491