Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implemented getPersonalizationData #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akanshaa-18 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Implemented getPersonalizationData #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2b8026
Adding types in Personalize.js and Parseinstructions.js
Jun 25, 2025
3d33d94
Implemented getPersonalizationData
Jul 14, 2025
92ab997
Implemented getPersonalizationData
Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 22 additions & 1 deletion src/Personalize/ParseInstructions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,28 @@
import { PersonalizationData } from "./Personalize";

export type Instruction = unknown;
export type Instruction = FragmentInstruction | CommandInstruction;

export type FragmentInstruction = {
type: "FragmentInstruction";
selector: string;
val: string;
action: string;
Copy link
Collaborator

@sharmrj sharmrj Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of allowing this to be any arbitrary string, make a type Action where you enumerate what the different actions can be

type Action = 'InsertBefore' | 'InsertAfter' | 'Delete' | 'Replace' // For example

manifestId: string;
targetManifestId: string | undefined;
};

export type CommandInstruction = {
type: "CommandInstruction";
action: string;
selector: string;
content: string;
selectorType: string;
manifestId: string;
targetManifestId: string | undefined;
modifiers?: string[];
attribute?: string;
completed?: boolean;
};
export const parseInstructionsFrom = async (
personalizationData: PersonalizationData
): Promise<Instruction[]> => {
Expand Down
Loading