Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Gradle to 8.10 and Kotlin-DSL #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Aug 27, 2024
Merged

Update Gradle to 8.10 and Kotlin-DSL #56

merged 17 commits into from
Aug 27, 2024

Conversation

@sdavids
Copy link
Contributor

@sdavids sdavids commented Aug 24, 2024 •
edited
Loading

  • updated all dependencies
  • migrated build.gradle to Kotlin-DSL
  • migrated settings.gradle to Kotlin-DSL
  • ensure reproducible build
  • minor fix to shell script

I suggest you review commit-by-commit …

@sdavids sdavids mentioned this pull request Aug 24, 2024
Closed
sdavids added 17 commits August 24, 2024 20:30
@sdavids
Fix SC2086
cd01f48 
https://www.shellcheck.net/wiki/SC2086

Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update actions/setup-java to v4
492169d 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Use temurin instead of adopt
9937bf0 
https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions

Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update jimfs to 1.3.0
80a12a4 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update hamcrest to 3.0
d66e104 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update junit to 5.11.0
25e28ac 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update picocli to 4.7.6
92ffc2a 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update jansi to 2.4.1
56ef747 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update shadow plugin to 8.3.0
1a67068 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Remove unnecessary maven files from release jar
38d862e 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Remove unnecessary transformer; log4j2 is not used
26fd64e 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Update Gradle to 8.10
d033100 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Specify Gradle Daemon JVM
151fb26 
https://docs.gradle.org/current/userguide/gradle_daemon.html#daemon_jvm_criteria

Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Migrate settings.gradle to Kotlin-DSL
7be4835 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Migrate build.gradle to Kotlin-DSL
d01b359 
Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Make build reproducible
4728bba 
https://docs.gradle.org/current/userguide/working_with_files.html#sec:reproducible_archives

https://docs.gradle.org/current/userguide/resolution_strategy_tuning.html#sec:java_consistency

Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Use version catalog
68a96e5 
https://docs.gradle.org/current/userguide/platforms.html#sub:central-declaration-of-dependencies

Signed-off-by: Sebastian Davids <[email protected]>
@sdavids
Copy link
Contributor Author

sdavids commented Aug 24, 2024

I have not included the gradle-graal plugin due to it not being updated in 2 years.

It has not kept up with the changes in Gradle 8 nor the ones for the upcoming Gradle 9.

Also, there are several important open issues:

I really don't know why this plugin is so strict about the graalvm and jdk version, every single time Graal upgrades the plugin stops working.

The plugin seems to be abondoned.

@sdavids sdavids marked this pull request as ready for review August 24, 2024 21:03
@sdavids
Copy link
Contributor Author

sdavids commented Aug 24, 2024

https://graalvm.github.io/native-build-tools/latest/gradle-plugin.html#configuration-toolchains-enabling

would be an alternative plugin.

@adoble adoble merged commit 90429ee into adoble:main Aug 27, 2024
@adoble
Copy link
Owner

adoble commented Aug 27, 2024

I agree with your appraisal of GraalVM and are happy to leave it out (I'll mention in the CHANGELOG that this is the case).

If anybody has a need for this, then please raise an issue.

@sdavids sdavids deleted the users/sdavids/feat/issue-55 branch August 27, 2024 15:06
@adoble adoble mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sdavids @adoble