Added "from_r0" to Burkert potential #370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrn
reviewed
Aug 22, 2024
Owner
|
Sorry for the long delay! I rebased your PR, so pull locally before you make any additional changes. I left one suggested change and one comment on the implementation. Thanks! |
adrn
reviewed
Aug 22, 2024
adrn
approved these changes
Aug 22, 2024
Owner
|
Thanks @HSouch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to generate the Burkert potential from just the r0
This is standard practice, as it is ultimately a 1-parameter potential. The relationship between density and core radius is described in Equations 4 and 5 of Mori & Burkert 2000.
Checklist
CHANGES.rst)