-
Notifications
You must be signed in to change notification settings - Fork 44
Add support for RISC-V as a host #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikhaylovilya
wants to merge
32
commits into
aengelke:master
Choose a base branch
from
mikhaylovilya:tmp-host-riscv64
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b56ed0 to
13b0b05
Compare
Theodor
reviewed
May 26, 2025
client/minilibc.c
Outdated
|
|
||
| ASM_BLOCK( | ||
| .globl __restore; | ||
| .type __rectore, %function; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR adds support for running statically linked binaries with Instrew on RISC-V host.
Testing
All Instrew tests passed successfully on Sipeed Lichee PI 4A and a Debian VM, but almost all of the Rellume JIT tests didn't pass due to segfault in LLVM Runtime. I believe the reason is in poor JIT support for RISC-V in LLVM <= 18. Also I've added a few more rv64 testcases.