Image.reject() #1785
Merged
Image.reject() #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeb01
reviewed
May 20, 2025
mikeb01
reviewed
May 21, 2025
mikeb01
reviewed
May 21, 2025
|
I'm happy with this as a whole. I think if we could make the counter changes, then I would be happy for it to be merged. |
vyazelenko
requested changes
May 21, 2025
aeron-driver/src/main/java/io/aeron/driver/status/SystemCounterDescriptor.java
Outdated
Show resolved
Hide resolved
|
@nbradac The new counter should be also incremented when rejecting a UDP image, i.e. either inside of DriverConductor#onRejectImage or PublicationImage#reject. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.