[Java/C] Prevent NetworkPublication's pub-lmt from wrapping around into the dirty term.
#1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vent dirty data from being consumed (i.e. by sender or spies).
…t dirty data from being consumed (i.e. by sender or spies).
vyazelenko
added a commit
that referenced
this pull request
May 9, 2025
…into the dirty term. (#1794) * [Java] Update `pub-lmt` on reaching the trip gain boundary. * [Java] Prevent `pub-lmt` from wrapping around into dirty terms to prevent dirty data from being consumed (i.e. by sender or spies). * [Java] Update tests. * [C] Increment work count when `pub-lmt` is reset. * [C] Prevent `pub-lmt` from wrapping around into dirty terms to prevent dirty data from being consumed (i.e. by sender or spies). * [C] Align naming with the Java impl. * [Java] Clarify logic using termId-based calculation. * [C] Clarify logic using termId-based calculation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that
pub-lmtalways stays within a safe boundary, i.e.:Explanation:
pub-lmtis a soft constraint, i.e. it can be breached by a publisher but only within a term boundary. This means that if the publisher fills an entire term and the following term is a dirty one then subscribers (sender or spies) might start reading the dirty data before conductor has a chance to clean it up. Therefore if the clean position is at the term start we don't allowpub-lmtto be in the previous term.