Thanks to visit codestin.com
Credit goes to github.com

[Java] Flow control retransmit receiver window multiple #1800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vyazelenko merged 4 commits into aeron-io:master from nickelaway:flow_control_rrwm

May 21, 2025

Contributor

nickelaway commented May 12, 2025

No description provided.

nickelaway added 3 commits

May 11, 2025 19:12


          [Java] Allow retransmit receiver window multiple to be configured in …

e717d10

…the max flow control strategy


          [Java] Allow retransmit receiver window multiple to be configured in …

9b69679

…other multicast flow control strategy


          [Java] Allow retransmit receiver window multiple to be configured in …

ce15195

…the unicast flow control strategy

nickelaway requested a review from mikeb01

May 12, 2025 17:25

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/Configuration.java Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/Configuration.java Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/MediaDriver.java Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/MediaDriver.java Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/MediaDriver.java Outdated Show resolved Hide resolved

mikeb01 reviewed

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/MediaDriver.java Outdated Show resolved Hide resolved

Contributor

mikeb01 commented May 20, 2025

Overall looks good. Only one real comment based on naming convention. Needs C driver implementation.


          [Java] Update naming for flow control window multiple to match the no…

09af066

…rmal convention

nickelaway marked this pull request as ready for review

May 20, 2025 18:57

vyazelenko changed the title ~~Flow control retransmit receiver window multiple~~ [Java] Flow control retransmit receiver window multiple

vyazelenko merged commit 1a49483 into aeron-io:master

45 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet