Add WAI-ARIA role to the nav element for accessibility. #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epub accessibility checkers require that all epub:type rules which have corresponding ARIA roles use both. The ebooklib serializer for the nav element doesn't provide any entry point to manually add the `doc-toc` role. This change programmatically adds `role="doc-type"` to the nav at the same point at which `epub:type="toc"` is added. References: * [The EPUB-specific rules at the DAISY Ace epub accessibility checker](https://daisy.github.io/ace/rules/epub/) * [doc-toc role in the Digital publishing WAI-ARIA module 1.0](https://www.w3.org/TR/dpub-aria-1.0/#doc-toc)
|
Thanks for this. Also thanks for the references, I was not aware of Ace epub accessibility checker. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epub accessibility checkers require that all epub:type rules which have corresponding ARIA roles use both. The ebooklib serializer for the nav element doesn't provide any entry point to manually add the
doc-tocrole. This change programmatically addsrole="doc-type"to the nav at the same point at whichepub:type="toc"is added.References: