timezone-aware datetime object conversion fix #897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement check and handling for timezone-aware datetime objects, converting them to timezone-naive for the .astype() numpy conversion function to work properly and not throw a TypeError if the dataframe has any timezone-aware datetime objects.
The issue is attempted conversion via numpy's .astype() function via
df[col[0]] = df[col[0]].astype(data_type)with"datetime64[ns]"as the data type on datetime objects with a timezone.Numpy will throw the below error if there are any timezone-aware datetime objects in the dataframe:
The proposed fix allows the dataframe to have timezone-aware datetime objects and still use skimpy to visualize the data analysis.
This can be tested with dummy data such as below: