-
Notifications
You must be signed in to change notification settings - Fork 481
feat: support context manager usage for LLMConfig #1777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support context manager usage for LLMConfig #1777
Conversation
…nd AgentOptimizer
|
|
|
@mukundkumarjha: Could you please sign the CLA. |
|
@harishmohanraj Done |
|
Could you please double-check the CLA? The badge still shows as "not signed yet." In the meantime, I had a quick look at your changes. Could you please add or update the relevant tests? You can refer to the following test files:
|
You have signed the CLA already but the status is still pending? Let us recheck it. this is the message what I can see, when trying to recheck I am begin redirected to the same page. :( |
Co-authored-by: Kumaran Rajendhiran <[email protected]>
Co-authored-by: Kumaran Rajendhiran <[email protected]>
|
@mukundkumarjha could you check again on CLA? Thanks for the contribution! Nice work! |
|
@qingyun-wu Thanks for your kind words. I have already signed Cla I have attached ss for reference. |
|
Thanks @mukundkumarjha! One thing you need to do: Several PR checks are failing. Check the error msgs to fix. Shouldn't be too difficult to fix. You can check our contributing guide for more detailed instructions: https://docs.ag2.ai/latest/docs/contributor-guide/pre-commit/ @marklysze Please help if @mukundkumarjha has difficulty in resolving the issues. Thanks both! |
|
@mukundkumarjha, can I have your email? Thanks! |
sure, [email protected] |
|
@mukundkumarjha would you be able to give me access to write to your fork and I'll help with the fixes? @marklysze is my username |
|
Done. |
|
@mj2472 can you please sign the CLA |
Thanks @mukundkumarjha, I've made an update to use Can you test it yourself and make sure it's working as you expect? |
Codecov ReportAttention: Patch coverage is
... and 57 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Fixes #1774
This PR adds support for context manager usage of LLMConfig in components outside of agents. Specifically:
Changes:
This allows these components to be used with the
with llm_config:syntax, similar to how it's used in agents.Example usage: