Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix Gemini tool call message handling and handle failed responses with empty-content #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

Fix Gemini tool call message handling and handle failed responses with empty-content #1916

merged 4 commits into from
Jun 26, 2025

Conversation

@marklysze
Copy link
Collaborator

@marklysze marklysze commented Jun 25, 2025 •
edited
Loading

Why are these changes needed?

  • Handle Gemini client finish failures more gracefully.
  • Fix a bug that occurred where the message structure for tool calls wasn't being supported.

Related issue number

N/A

Checks

@marklysze marklysze changed the title Handle Gemini finish failures more gracefully Fix Gemini tool call message handling and handle empty-content responses Jun 26, 2025
@marklysze marklysze changed the title Fix Gemini tool call message handling and handle empty-content responses Fix Gemini tool call message handling and handle failed responses with empty-content Jun 26, 2025
@marklysze marklysze requested a review from randombet June 26, 2025 00:18
@marklysze marklysze merged commit f0bbec3 into main Jun 26, 2025
26 checks passed
@marklysze marklysze deleted the gemini-finish-reason-other branch June 26, 2025 00:45
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 15 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
autogen/oai/gemini.py 16.66% 10 Missing and 5 partials ⚠️
Files with missing lines Coverage Δ
autogen/oai/gemini.py 58.48% <16.66%> (+40.72%) ⬆️

... and 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@randombet randombet Awaiting requested review from randombet

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@marklysze