feat:[MCPClientSessionManager] can manage SSE and Stdio session both #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lancetnik
reviewed
Aug 5, 2025
Lancetnik
reviewed
Aug 5, 2025
Lancetnik
reviewed
Aug 5, 2025
There was a problem hiding this comment.
Looks good, but I think it could be better a bit.
if isinstance(config, StdioConfig):
async with self.create_stdio_session(config) as session:
yield session
elif isinstance(config, SseConfig):
async with self.create_sse_session(config) as session:
yield sessionThis code looks not scalable. I suggest to move create_session method to StdioConfig and SseConfig and hide them by the same interface. MCPClient should return just an interface call result this way
@asynccontextmanager
async def open_session(
self,
config: SessionConfigProtocol,
) -> AsyncIterator[ClientSession]:
async with config.create_session(self.exit_stack) as session:
yield session
Lancetnik
reviewed
Aug 5, 2025
9f51b68 to
e30e4c0
Compare
Lancetnik
reviewed
Aug 6, 2025
|
@marklysze hi! The code looks fine, but can you help me with tests a bit? I am not familiar enought with your testing practice yet |
…rt-in-mcpclientsessionmanager
Lancetnik
approved these changes
Aug 6, 2025
Lancetnik
approved these changes
Aug 7, 2025
Codecov Report❌ Patch coverage is
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
MultiMCPSessionManager class can support both Stdio and SSE session now.
Related issue number
Closes #1975
Checks