Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@danfimov
Copy link
Collaborator

@danfimov danfimov commented Aug 6, 2025

Why are these changes needed?

Fix list rendering in contribution guide part of docs:

  • Lists need empty string if they used right after plain text (not special blocks like heading / tab / code example)
  • Nested lists need additional indent (4 spaces)
Before After
image image
image image

Related issue number

Relevant to #1985, but this issue not quite about that particular problem.

Checks

@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 01:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes markdown list rendering issues in the contribution guide documentation. The changes ensure proper list formatting by adding empty lines before lists that follow plain text and adjusting indentation for nested lists.

  • Adds empty lines before lists to ensure proper markdown rendering
  • Fixes nested list indentation to use 4 spaces instead of 2
  • Updates multiple documentation files in the contributor guide section

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/docs/contributor-guide/maintainer.mdx Adds empty line before nested list under "Pay special attention to"
website/docs/contributor-guide/how-ag2-works/generate-reply.mdx Adds empty lines before multiple nested lists in the generate_reply process
website/docs/contributor-guide/contributing.mdx Adds empty lines before various lists throughout the contributing guide
website/docs/contributor-guide/building/creating-an-agent.mdx Adds empty lines before pros/cons lists and documentation requirements
website/docs/contributor-guide/building/creating-a-tool.mdx Adds empty line before documentation requirements list

@danfimov danfimov added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit e13412a Aug 6, 2025
16 checks passed
@danfimov danfimov deleted the docs-fix-all-lists-in-contributor-guide branch August 6, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants