Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@VasiliyRad
Copy link
Contributor

Why are these changes needed?

Made it easier for new developers to get started:

  • added installation instructions for Mac
  • clarified why OAI_CONFIG_LIST should be used and what specific name can be chosen
  • reordered examples. Example for human in the loop now builds on the previous example with multiple agents
  • replaced the first example - the previous version was confusing since agents created code that had to be ran manually
  • followed the same pattern for LLM config across all examples
  • replaced print() with logging

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2025

CLA assistant check
All committers have signed the CLA.

@joggrbot

This comment has been minimized.

@marklysze
Copy link
Collaborator

I've also updated the second group chat example to move termination and use the new run_group_chat.

@Lancetnik
Copy link
Member

Lancetnik commented Sep 6, 2025

Also, I suggest to remove:

  • Code style and linting - section. Let's leave it on contributing guide
  • Cite the project - we have CITATION.cff already

And move Contributors Wall to the down of README. So, the ending sections order I suggest:
– Related papers
– Announcements
– License - can we use https://img.shields.io/github/license/ag2ai/ag2.svg shield instead?
– Contributors Wall

@priyansh4320 priyansh4320 self-requested a review September 7, 2025 17:25
@VasiliyRad
Copy link
Contributor Author

  • Code style and linting - section. Let's leave it on contributing guide
    Contributors guide is missing that information. Let's update contributors guide with that information first and next delete it from Readme.
  • Cite the project - we have CITATION.cff already
    Format is a bit different, also it is common for developers to just check README and ignore CITATION.cff. Let me think if we can optimize it in future.

And move Contributors Wall to the down of README. So, the ending sections order I suggest: – Related papers – Announcements – License - can we use https://img.shields.io/github/license/ag2ai/ag2.svg shield instead? – Contributors Wall
Moved down but not completely to the bottom. The legal section should probably be last (along with the related citation section)

Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VasiliyRad, thanks!

@marklysze marklysze added this pull request to the merge queue Sep 16, 2025
Merged via the queue into main with commit 8297621 Sep 16, 2025
17 checks passed
@marklysze marklysze deleted the vasiliyr/09042025 branch September 16, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants