-
Notifications
You must be signed in to change notification settings - Fork 487
[docs] update config list filtering examples to allow string or list #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] update config list filtering examples to allow string or list #2109
Conversation
Discussion / Follow-upsI’m keeping this as an open discussion on whether we should maintain examples for both single and multiple models, or simplify to lists only. Advantages of keeping both examples:
Future work: |
|
@aakash232 Did you verify the documented use cases for config_list is working? How did you do that? |
@randombet Based on the discussions (in github), I went ahead and supported the proposal + usage of "pass as a string" pattern. P.S. Another solid check would be to do this in all notebooks. (Which points to the creation of a new issue/PR, as stated) |
|
@aakash232 Please follow https://docs.ag2.ai/latest/docs/contributor-guide/pre-commit/ and fix the error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 41 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Why are these changes needed?
This PR improves the documentation for
config_listfiltering by:"model": "gpt-5-nano"or"model": ["gpt-5-nano", "gpt-4.1"]).filter_configdocstring inopenai_utils.py— now aligned with the main docs:filter_dictsupports both single string and list/set inputs.These changes make the docs more flexible, consistent, and user-friendly.
Related issue number
Closes #1823
Screenshots (Locally Served)
Checks