Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Taneb
Copy link
Member

@Taneb Taneb commented Dec 13, 2023

Closes #405. Supercedes #352.

I ran into difficulty trying to make Categories.Yoneda work with the new function hierarchy so I'm opening this as a draft.

Many of the changes could be made tidier.

Difficulties encountered so far:

  • Categories.Category.Instance.Setoids and Categories.Adjoint.Mate could both do with a definition of equality of functions between setoids. I've inlined it for the former but didn't for the latter, because we just want the relation and it'd be too much of a mess to define it there locally too.
  • I got sufficiently confused by Categories.Yoneda that I bounced off it. I may give this another go at some point.

Other maintainers of the library are explicitly invited to contribute to this PR.

Taneb added 29 commits December 13, 2023 18:02
Didn't notice that I'd ended up in Functor.Instance in the previous commit
I couldn't get the proofs working with Surjective yesterday so I used SplitSurjective instead but that turned out to be too strict later
@Taneb
Copy link
Member Author

Taneb commented Dec 16, 2023

Status: I've been working through the modules in alphabetical order. I've skipped Categories.Adjoint.Mate because it would hugely benefit from having a definition of equality of functions between setoids somewhere, and its dependents. Currently up to Categories.Category.Instance.FamilyOfSetoids, but I won't have much time to work on it in the next few days

@Taneb Taneb marked this pull request as ready for review December 22, 2023 11:43
@Taneb
Copy link
Member Author

Taneb commented Dec 22, 2023

Wow, @JacquesCarette, you've stormed through that!

@JacquesCarette
Copy link
Collaborator

I ended up spending close to 12 hours yesterday single-mindedly pushing through this. I'd definitely appreciate a review @Taneb . I know there's quite a few things to clean up, but that's so much easier than the first pass.

Copy link
Member Author

@Taneb Taneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick look through and highlighted (all minor) problems I've seen.

Can I ask you to take a close look at Categories.Functor.Properties, @JacquesCarette ? It probably has the most substantial changes

@JacquesCarette
Copy link
Collaborator

(I'm going to use the review facility to leave additional notes for myself)

Copy link
Collaborator

@JacquesCarette JacquesCarette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various notes to help in a cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support stdlib 2.0

3 participants