-
Notifications
You must be signed in to change notification settings - Fork 14
new way of detecting ads in Spotify #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
(rename to .apk restrictions in GitHub comments) |
|
@citizenserious can you test the above build. this only has a slight chance of working...but I have added logs that will help us find the thing we need. in the logcat, filter with |
fix logs
|
@aghontpi I tested 34 with different podcasts and languages. As far as I can tell it works perfectly. I installed 36 know, and will do the same. |
|
@aghontpi also build 36 works great. Mutes all ads in my case. Awesome! |
|
@citizenserious thank you soo much for testing. kindly share a In the mean time, I'll also continue testing with this build. |
|
@aghontpi no problem I was already testing build 34 before you shared the other builds. I would share the log, but I don't know how to right now, I am sorry. If you could explain it real quick, that would be nice (: Edit: I looked up logcat, is there a way to do it without a computer? My device is rooted btw. |
|
you can use this from fdroid or playstore |
|
@citizenserious thanks, I was able to update the logic. the following build should be more accurate I believe. kindly update to this. (rename to .apk restrictions in GitHub comments) |
I tested it again, the new build misses the ad I attached below. I also added the logcat again. "Werbung von Gerolsteiner" means translated "Advertisement from Gerolsteiner" both logs were taken while the Gerolsteiner ad was playing, with an ad for another podcast in between. It seems like the ad doesn't even appear in the log if I am not wrong. That is why I took a second logcat to make sure I didn't missed it somehow. |
|
@citizenserious, yea, it does not seem to appear. maybe try the record option, because it is highly unlikely that Spotify does not update the notification... |
|
@aghontpi You were right (: I caught it with the recording |
|
@citizenserious thanks so much. for this
only option is to regex match the word "Advertisement"/ "Werbung" - translated We already have it here, but we do exact match. I'll update it to check if
this only seems to occur in podcasts 🤔 |
|
(rename to .apk restrictions in GitHub comments) |
@aghontpi works perfectly (: thank you so much, if you need another logcat, just let me know. |
|
Thank you @citizenserious |
refer #63
Test out new ad detection for Spotify.
On top of the existing detections, added new logic to detect ads, if the old logic does not catch the ads, the new logic is activated.
did not remove old detection because that might cause bugs/unexpected behaviour in existing flow.
closes #63