Fix: Variable 'result' is referenced before assignment in Get Knowledge Contents MySQLDb #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willemcdejongh
approved these changes
Oct 14, 2025
anuragts
pushed a commit
that referenced
this pull request
Oct 14, 2025
…ge Contents MySQLDb (#5019) ## Summary In Knowledge class: - `get_content` calls `get_knowledge_contents` from `BaseDb`, in this case I am using `MySQLDb`. - `get_content` is called in `_get_filters_from_db` which is called in `validate_filters` - When adding `search_knowledge_base` tool in Team or Agent, `validate_filters` is called. However, in MySQLDb, get_knowledge_contents is buggy in MySQLDb. In the current implementation. If there is no limit provided, the query won't be executed at all. (If applicable, issue number: #5018) ## Type of change - [X] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Improvement - [ ] Model update - [ ] Other: --- ## Checklist - [X] Code complies with style guidelines - [X] Ran format/validation scripts (`./scripts/format.sh` and `./scripts/validate.sh`) - [X] Self-review completed - [ ] Documentation updated (comments, docstrings) - [ ] Examples and guides: Relevant cookbook examples have been included or updated (if applicable) - [X] Tested in clean environment - [ ] Tests added/updated (if applicable) --- ## Additional Notes Add any important context (deployment instructions, screenshots, security considerations, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In Knowledge class:
get_contentcallsget_knowledge_contentsfromBaseDb, in this case I am usingMySQLDb.get_contentis called in_get_filters_from_dbwhich is called invalidate_filterssearch_knowledge_basetool in Team or Agent,validate_filtersis called.However, in MySQLDb, get_knowledge_contents is buggy in MySQLDb.
In the current implementation. If there is no limit provided, the query won't be executed at all.
(If applicable, issue number: #5018)
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)