fix: Remove render_heavy_js argument from ScrapeGraphTools.searchscraper #5031
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kausmeows
approved these changes
Oct 14, 2025
|
Thanks for this @k3vob i've raised this issue in their repo as well- ScrapeGraphAI/Scrapegraph-ai#1014 |
anuragts
pushed a commit
that referenced
this pull request
Oct 14, 2025
…per (#5031) ## Summary Describe key changes, mention related issues or motivation for the changes. Issue number: [#5030](#5030) ## Type of change - [X] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Improvement - [ ] Model update - [ ] Other: --- ## Checklist - [X] Code complies with style guidelines - [X] Ran format/validation scripts (`./scripts/format.sh` and `./scripts/validate.sh`) - [X] Self-review completed - [X] Documentation updated (comments, docstrings) - [X] Examples and guides: Relevant cookbook examples have been included or updated (if applicable) - [X] Tested in clean environment - [X] Tests added/updated (if applicable) --- ## Additional Notes Add any important context (deployment instructions, screenshots, security considerations, etc.) --------- Co-authored-by: Kaustubh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe key changes, mention related issues or motivation for the changes.
Issue number: #5030
Type of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)