fix: Various issues with team history #5104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is expected_output being removed? While I don't rely on it, I have seen my team use it - is this something that was causing issues? I asking only bc I have custom overrides for all the task delegation methods to fix some issues I was experiencing and this change would technically break it I guess Also team_history_str - What is this coming to solve? Sharing the team general information with subagents? |
|
|
Got it - thanks |
ysolanky
reviewed
Oct 22, 2025
adiberk
reviewed
Oct 22, 2025
Co-authored-by: Yash Pratap Solanky <[email protected]>
manuhortet
approved these changes
Oct 22, 2025
guyrosin
pushed a commit
to guyrosin/agno
that referenced
this pull request
Oct 23, 2025
## Summary - This removes `expected_output` from delegate_task_to_member - This adds the top-level field `add_team_history_to_members` that works the same as `add_workflow_history_to_steps` - Add various examples to show how this works ## Type of change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Improvement - [ ] Model update - [ ] Other: --- ## Checklist - [ ] Code complies with style guidelines - [ ] Ran format/validation scripts (`./scripts/format.sh` and `./scripts/validate.sh`) - [ ] Self-review completed - [ ] Documentation updated (comments, docstrings) - [ ] Examples and guides: Relevant cookbook examples have been included or updated (if applicable) - [ ] Tested in clean environment - [ ] Tests added/updated (if applicable) --- ## Additional Notes Add any important context (deployment instructions, screenshots, security considerations, etc.) --------- Co-authored-by: Yash Pratap Solanky <[email protected]>
Mustafa-Esoofally
pushed a commit
that referenced
this pull request
Oct 23, 2025
## Summary - This removes `expected_output` from delegate_task_to_member - This adds the top-level field `add_team_history_to_members` that works the same as `add_workflow_history_to_steps` - Add various examples to show how this works ## Type of change - [x] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Improvement - [ ] Model update - [ ] Other: --- ## Checklist - [ ] Code complies with style guidelines - [ ] Ran format/validation scripts (`./scripts/format.sh` and `./scripts/validate.sh`) - [ ] Self-review completed - [ ] Documentation updated (comments, docstrings) - [ ] Examples and guides: Relevant cookbook examples have been included or updated (if applicable) - [ ] Tested in clean environment - [ ] Tests added/updated (if applicable) --- ## Additional Notes Add any important context (deployment instructions, screenshots, security considerations, etc.) --------- Co-authored-by: Yash Pratap Solanky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
expected_outputfrom delegate_task_to_memberadd_team_history_to_membersthat works the same asadd_workflow_history_to_stepsType of change
Checklist
./scripts/format.shand./scripts/validate.sh)Additional Notes
Add any important context (deployment instructions, screenshots, security considerations, etc.)