feat: introduce culture #5124
feat: introduce culture #5124
Conversation
|
|
||
| return await self.db.get_cultural_knowledge(id=id) | ||
|
|
||
| def get_all_knowledge(self, name: Optional[str] = None) -> Optional[List[CulturalKnowledge]]: |
There was a problem hiding this comment.
get_knowledge and get_all_knowledge can be combined with optional filters for id and name?
Btw why is name here?
There was a problem hiding this comment.
- Can be combined. We should do the same for Memory.
- Name is there as potential filter
| message: Optional[str] = None, | ||
| messages: Optional[List[Message]] = None, |
There was a problem hiding this comment.
Is this actually a good pattern? It made sense when we had message and messages, but should it not just be str for our experiment?
There was a problem hiding this comment.
message is used when we generate the item given the user message, messages when it's based on a conversation --- it could totally be just messages here. Would need refactor in the agent logic
We should also adjust for both memory and culture
|
|
||
|
|
||
| @dataclass | ||
| class CultureManager: |
There was a problem hiding this comment.
wdyt about a base class, and then we have CultureManager and AsyncCultureManager with the same functions, but one is sync and other is async?
There was a problem hiding this comment.
In general I think that is a better pattern for these kinds of classes (we should do memory like that as well I think)
There was a problem hiding this comment.
Yeah good - we actually just introduced that pattern with the async dbs. It is cleaner.
We should also adjust for both memory and culture
|
|
||
| return response | ||
|
|
||
| def update_culture_task(self, task: str) -> str: |
There was a problem hiding this comment.
What is the difference really with the above? Could they be the same?
There was a problem hiding this comment.
These orchestrate generation of the learning, the other ones are to persist the generated learning I think. The pattern comes from the MemoryManager too. Combining both would simplify usage from the Agent if I'm understanding the setup
We should adjust for both memory and culture
| return Message(role="system", content=self.system_message) | ||
|
|
||
| # Default capture instructions | ||
| culture_capture_instructions = self.culture_capture_instructions or dedent( |
There was a problem hiding this comment.
Only such a small part is configurable... but this is fine for now
Changes: - Introduces a Culture Manager to define and manage the cultural context within your Agents. - Related cookbooks showing usage --------- Co-authored-by: Ashpreet <[email protected]> Co-authored-by: Yash Pratap Solanky <[email protected]> Co-authored-by: ysolanky <[email protected]>
Changes: