fix: Use self.encoding in CSV readers for BytesIO inputs #6049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSVReader and FieldLabeledCSVReader were ignoring the encoding parameter when reading from BytesIO objects, always using hardcoded "utf-8". Changes: - csv_reader.py: 3 places now use self.encoding or "utf-8" - field_labeled_csv_reader.py: 2 places now use self.encoding or "utf-8" - Added 8 encoding tests across both readers Co-Authored-By: Claude <[email protected]>
Contributor
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of PR #6032 targeting v2.4.0.
CSVReader and FieldLabeledCSVReader ignored
encodingparameter for BytesIO inputs - always used hardcoded"utf-8"instead ofself.encoding or "utf-8".Changes
self.encoding or "utf-8"for BytesIO decoding in sync and async methodsOriginal PR
#6032 (was merged to knowledge-ga-updates)