feat(schema, server): customizable map type #331
Merged
+207
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
Signed-off-by: András Jáky <[email protected]>
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
nit: suggestion on UI string for map types, we could have |
ramizpolic
approved these changes
Oct 10, 2025
Signed-off-by: András Jáky <[email protected]>
1d365a5 to
e1f109f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new type to the dictionary called
typed_map_t, in which the type of the value can be any dictionary type (key is always string to produce a valid JSON).This also replaces the
string_map_twhich was created to enforce a map where the values could only be strings.Change on the UI is in the Type of the
annotationsattribute here:Closes #209