Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 22, 2022. It is now read-only.

a2b inlined #515

Draft
rheacangeo wants to merge 43 commits into
base: master
Choose a base branch
from
Draft

a2b inlined #515

rheacangeo wants to merge 43 commits into from

Conversation

@rheacangeo
Copy link
Contributor

@rheacangeo rheacangeo commented May 26, 2021

Purpose

Excessive/ugly inlining of refactored a2b_ord4

Code changes:

  • a2b_ord4 is less stencils

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • Unit tests are added or updated for non-stencil code changes

Additionally, if this PR contains code authored by new contributors:

  • The names of all the new contributors have been added to CONTRIBUTORS.md

rheacangeo added 30 commits May 4, 2021 15:50
@rheacangeo
remerge ppm_volume_mean_x and y back into a2b_interpolation
40add50
@rheacangeo
is using extra variables any faster
8be8be8
@rheacangeo
Revert "is using extra variables any faster"
2b01c89 
This reverts commit 8be8be8.
@rheacangeo
Revert "remerge ppm_volume_mean_x and y back into a2b_interpolation"
5f4a5f5 
This reverts commit 40add50.
@rheacangeo
Merge remote-tracking branch 'origin/master' into fastera2b
442ec91
@rheacangeo
merge ppm_volume_mean stencils into a2b_interpolation
674e919
@rheacangeo
using an extra variable
ed9b5e1
@rheacangeo
intermediate qout edges commit
46f1b93
@rheacangeo
qout edges cleanup
5e28d5b
@rheacangeo
put edges back into a2b interpolation
17f45f9
@rheacangeo
put replace into a2b interpolation
02ca216
@rheacangeo
Revert "put replace into a2b interpolation"
ce5b612 
This reverts commit 02ca216.
@rheacangeo
Revert "put edges back into a2b interpolation"
728b7ce 
This reverts commit 17f45f9.
@rheacangeo
Merge remote-tracking branch 'origin/master' into fastera2b
ba8aeb6
@rheacangeo
Merge remote-tracking branch 'origin/master' into fastera2b
8412c9d
@rheacangeo
Merge remote-tracking branch 'origin/master' into fastera2b
368269b
@rheacangeo
sw corner experiment
e3437ba
@rheacangeo
maybe can still use all the functions calling functions
6707db3
@rheacangeo
put the nw corner with the sw corner
adbd45e
@rheacangeo
all corners
8281a01
@rheacangeo
excessive recursion reached, split 4 corners into 2 stencils. also wo…
a52633a 
…rking on removing copy variables
@rheacangeo
remove copy vars
99e7ceb
@rheacangeo
merged qout edges and replace into a2b_interpolation, eliminated q1 a…
be7da0d 
…nd q2 as separate variables
@rheacangeo
qxx and qyy regions do not rely on value in main domain
975de17
@rheacangeo
lint
c81a67a
@rheacangeo
a2b not validating again, splitting apart qx, qxx and final qout
b102c2c
@rheacangeo
Revert "a2b not validating again, splitting apart qx, qxx and final q…
8abb14c 
…out"

This reverts commit b102c2c.
@rheacangeo
cleanup unused methods
b674492
@rheacangeo
Revert "cleanup unused methods"
d62e2fd 
This reverts commit b674492.
@rheacangeo
Revert "Revert "a2b not validating again, splitting apart qx, qxx and…
07d2fa8 
… final qout""

This reverts commit 8abb14c.
rheacangeo and others added 13 commits May 19, 2021 12:12
@rheacangeo rheacangeo marked this pull request as draft May 28, 2021 17:22
@jdahm jdahm added the inactive Not currently worked on label Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

inactive Not currently worked on

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rheacangeo @jdahm