This repository was archived by the owner on Dec 22, 2022. It is now read-only.
fix GnomonicGrid and MirrorGrid tests and disable the AAMCorrection #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est as the reason for failure on c48_6ranks needs more invesitgation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the GnomonicGrid and MirrorGrid tests, which run on global tile data and do not need to be local grid quantities to be tested.
The reason for AAMCorrection failure is unclear (large validation miss), and is thus disabled. We don't currently need the grid variables it produces. If we add support for consv_am we will need to re-enable this. Both variables fail with a metric error of 0.01, but the absolute values are tiny. This uses a number of methods that reflect, but do not exactly imitate the fortran function behaviors, so a closer look would be needed to determine if these errors are fixable.