Enable linting in physics #48
Conversation
| .*/__init__.py | | ||
| fv3gfs-physics/.* | ||
| )$ | ||
| - id: flake8 | ||
| name: flake8 __init__.py files | ||
| files: "__init__.py" | ||
| # ignore unused import error in __init__.py files | ||
| args: ["--ignore=F401,E203", --config, setup.cfg] | ||
| exclude: | | ||
| (?x)^( | ||
| fv3gfs-physics/.* | ||
| )$ |
There was a problem hiding this comment.
What you'll need to do here is delete the fv3gfs-physics entry from the first exclude but leave the init.py one, and delete the exclude section altogether from the second entry. There should still be two flake8 entries.
| # - id: mypy | ||
| # args: [ | ||
| # --no-strict-optional, | ||
| # --ignore-missing-imports, | ||
| # --follow-imports, skip # needed so we only test enabled files | ||
| # ] | ||
| # files: fv3gfs-physics |
There was a problem hiding this comment.
You should restore and uncomment this entry.
mcgibbon
left a comment
There was a problem hiding this comment.
Thanks for enabling this! I hope it wasn't too much work to update all those constants references.
| from gt4py.gtscript import exp, log, sqrt | ||
|
|
||
| from fv3gfs.physics.global_constants import * | ||
| import fv3gfs.physics.global_constants as constants |
There was a problem hiding this comment.
On one hand the math looks a little weird with constants everywhere, but on the other hand it's really helpful to be able to read the code and know what is a constant and what is a variable.
| mp_time = 225.0 # Maximum microphysics timestep (sec) | ||
| prog_ccn = 0 # Do prognostic ccn (yi ming's method) | ||
| qi0_crt = 8e-05 # Cloud ice to snow autoconversion threshold (highly dependent on horizontal resolution) | ||
| qi0_crt = 8e-05 # Cloud ice to snow autoconversion threshold |
There was a problem hiding this comment.
is it OK to remove that from this comment? You could continue the comment on the next line.
| from gt4py.gtscript import BACKWARD, PARALLEL, computation, interval | ||
|
|
||
| from fv3gfs.physics.global_config import * | ||
| from fv3gfs.physics.global_config import FIELD_FLT |
There was a problem hiding this comment.
Probably not about this PR but what is a FIELD_FLT and how is it different from a FloatField?
There was a problem hiding this comment.
There's no difference actually. Let me clean this up.
|
|
||
| # - pihom: homogeneous freezing of cloud water into cloud ice | ||
| # - This is the 1st occurance of liquid water freezing in the split mp process | ||
| # - This is the 1st occurance of liquid water freezing |
There was a problem hiding this comment.
| # - This is the 1st occurance of liquid water freezing | |
| # - This is the 1st occurence of liquid water freezing |
| description="fv3gfs-physics is a gt4py-based physical parameterization \ | ||
| for atmospheric models", |
There was a problem hiding this comment.
Nit: You're not wrong but this is the style I see us use most often.
| description="fv3gfs-physics is a gt4py-based physical parameterization \ | |
| for atmospheric models", | |
| description=( | |
| "fv3gfs-physics is a gt4py-based physical parameterization " | |
| "for atmospheric models" | |
| ) |
…) (ai2cm#48) * [Feature] Guarding against unimplemented configuration (ai2cm#40) Guarding against unimplemented namelists options: - a2b_ord4 - d_sw - fv_dynamics - fv_subgridz - neg_adj3 - divergence damping - xppm - yppm Misc: - Fix `netcdf_monitor` not mkdir the directory - Add `as_dict` to the dycore state to dump the dycore more easily * Unused assert * Update fv3core/pace/fv3core/stencils/yppm.py Co-authored-by: Oliver Elbert <[email protected]> * Update fv3core/pace/fv3core/stencils/xppm.py Co-authored-by: Oliver Elbert <[email protected]> * Change NotImplemented to ValueError for n_sponge<3 * lint --------- Co-authored-by: Oliver Elbert <[email protected]>
In this PR, linting in
fv3gfs-physicsis enabled.