Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@elynnwu
Copy link
Collaborator

@elynnwu elynnwu commented Dec 6, 2021

Some more cleanup:

  • Delete global_config in physics, use shared float field instead
  • Typo and documentation cleanup

Copy link
Collaborator

@mcgibbon mcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment on lines +33 to +34
description="fv3gfs-physics is a gt4py-based physical parameterization "
"for atmospheric models",
Copy link
Collaborator

@mcgibbon mcgibbon Dec 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work without the parentheses surrounding the two strings? Interesting.

@elynnwu elynnwu merged commit c0840a7 into main Dec 6, 2021
@elynnwu elynnwu deleted the fix/enable-physics-linting branch December 6, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants